[Tex/LaTex] Command already defined (custom command)

countersmacrostikz-pgf

When compiling following code, I the compiler tells me that a command is already defined (the name is \c@b...).

\documentclass{article}

\usepackage{calc}
\usepackage{ifthen}
\usepackage{tikz}

\usepackage{verbatim}

\newcommand{\piepart}[5]
{
    \draw[thick,fill=#4] (0,0) -- (#1:1) arc (#1:#2:1) -- cycle;

    \pgfmathparse{0.5*#1+0.5*#2}
    \let\midangle\pgfmathresult
    \pgfmathtruncatemacro{\trunc}{\midangle}
    \ifthenelse{\trunc < 90}{
    \draw (\midangle:1) node[above right]{#3};
    }
    {
        \ifthenelse{\trunc < 180}{
        \draw (\midangle:1) node[above left]{#3};
        }
        {
            \ifthenelse{\trunc < 270}{
            \draw (\midangle:1) node[below left]{#3};
            }
            {
                \draw (\midangle:1) node[below right]{#3};
            }
        }
    }
    \pgfmathparse{min((#2-#1-10)/110*(-0.3),0)}
    \let\temp\pgfmathresult
    \pgfmathparse{max(\temp,-0.5) + 0.8}
    \let\innerpos\pgfmathresult
    \node at (\midangle:0.8) {#5};

}

\newcommand{\piechart}[1]
{
\newcounter{a}
\newcounter{b}
\foreach \p/\mcolor/\mname in #1
    {
        \setcounter{a}{\value{b}}
        \addtocounter{b}{\p}
        \piepart{\thea/100*360}
                    {\theb/100*360}
                    {\mname}{\mcolor}{\p\%}
    }
}

\begin{document}

\begin{tikzpicture}[scale=1.5]
\tikzstyle{every node}=[font=\tiny]
\piechart{{75/gray/A, 18/green/B, 7/red/C}}                 
\end{tikzpicture}
\begin{tikzpicture}[scale=1.5]
\tikzstyle{every node}=[font=\tiny]
\piechart{{75/gray/A, 18/green/B, 7/red/C}}                 
\end{tikzpicture}

\end{document}

If somebody knows what creates the error, or how to solve it, could they please tell me.

Thanks

Best Answer

There are two \newcounter calls inside the macro \pichart. When the macro is called the second time, then the counters are already defined and you get the error messages about already defined commands \c@a and \c@b, which are the internal command representation of the counters.

Move the \newcounter calls outside and reset the counters inside the macro:

\newcounter{a}
\newcounter{b}
\newcommand*{\piechart}[1]{%
  \setcounter{a}{0}%
  \setcounter{b}{0}%
  ...
}

Full example for completeness (and with larger fonts):

\documentclass{article}

\usepackage{calc}
\usepackage{ifthen}
\usepackage{tikz}

\usepackage{verbatim}

\newcommand{\piepart}[5]
{
    \draw[thick,fill=#4] (0,0) -- (#1:1) arc (#1:#2:1) -- cycle;

    \pgfmathparse{0.5*#1+0.5*#2}
    \let\midangle\pgfmathresult
    \pgfmathtruncatemacro{\trunc}{\midangle}
    \ifthenelse{\trunc < 90}{
    \draw (\midangle:1) node[above right]{#3};
    }
    {
        \ifthenelse{\trunc < 180}{
        \draw (\midangle:1) node[above left]{#3};
        }
        {
            \ifthenelse{\trunc < 270}{
            \draw (\midangle:1) node[below left]{#3};
            }
            {
                \draw (\midangle:1) node[below right]{#3};
            }
        }
    }
    \pgfmathparse{min((#2-#1-10)/110*(-0.3),0)}
    \let\temp\pgfmathresult
    \pgfmathparse{max(\temp,-0.5) + 0.8}
    \let\innerpos\pgfmathresult
    \node at (\midangle:0.8) {#5};

}

\newcounter{a}
\newcounter{b}
\newcommand{\piechart}[1]
{
    \setcounter{a}{0}%
    \setcounter{b}{0}%
    \foreach \p/\mcolor/\mname in #1
    {
        \setcounter{a}{\value{b}}
        \addtocounter{b}{\p}
        \piepart{\thea/100*360}
                    {\theb/100*360}
                    {\mname}{\mcolor}{\p\%}
    }
}

\begin{document}

\begin{tikzpicture}[scale=1.5]
    \tikzstyle{every node}=[font=\footnotesize]
    \piechart{{75/gray/A, 18/green/B, 7/red/C}}                 
\end{tikzpicture}
\begin{tikzpicture}[scale=1.5]
    \tikzstyle{every node}=[font=\footnotesize]
    \piechart{{75/gray/A, 18/green/B, 7/red/C}}                 
\end{tikzpicture}

\end{document}

Related Solutions

[Tex/LaTex] Rotate a node but not its content: the case of the ellipse decoration

The source of the difficulty is that ellipses are constructed in a particular way in TikZ. They are paths that start from the x-axis and proceed counter-clockwise around their centre. The vast majority of the time, the exact parametrisation doesn't matter. You appear to have found the one situation where it does!

In the actual question, you only want to be able to mirror the ellipse, and so draw it starting from the negative x-axis (the title of the question suggests a more flexible approach). That's actually not too hard since we can exploit the symmetry of the ellipse. The key is to provide it with a negative x-radius, since then it will start from the negative x-axis (and proceed clockwise, but we could correct for that by negating the y-radius as well). To do this, we interrupt the call from the node shape to the drawing command and flip the sign of the x-radius. The simplest way to do this is to redefine the \pgfpathellipse macro to do the negation and then call the original macro. The following code does this.

\documentclass{article}
\usepackage{tikz}
\usetikzlibrary{decorations,shapes,decorations.markings}
\makeatletter
\let\origpgfpathellipse=\pgfpathellipse
\def\revpgfpathellipse#1#2#3{%
  #2%
  \pgf@xa=-\pgf@x
  \origpgfpathellipse{#1}{\pgfqpoint{\pgf@xa}{0pt}}{#3}}
\makeatother

\tikzset{
  reversed ellipse/.style={
    ellipse,
    reverse the ellipse%
  },
  reverse the ellipse/.code={
    \let\pgfpathellipse=\revpgfpathellipse
  }
}
\begin{document}
\begin{tikzpicture}
\node[ellipse,
  draw,
  postaction={
    decorate,
    decoration={
      markings,
      mark=at position 1 with {
        \arrow[line width=5pt,blue]{>}
      }
    }
  }
] at (0,0) {hello world};

\node[reversed ellipse,
  draw,
  postaction={
    decorate,
    decoration={
      markings,
      mark=at position 1 with {
        \arrow[line width=5pt,blue]{>}
      }
    }
  }
] at (0,-2) {hello world};
\end{tikzpicture}

\end{document}

Here's the result:

rotated ellipse

(the arrow got clipped, but you can see where it lies)

[Tex/LaTex] How to define the default vertical distance between nodes

I don't really get the question so I hope this is what you wanted. If you include a full document (such that we copy paste and see the problem on our systems) things are much more easier.

Here, you can change the default setting within a scope but your block style had a node distance which was resetting every time it is issued. I've made it 2mm such that we can see the difference easier.

\documentclass[tikz]{standalone}
\usetikzlibrary{arrows,shapes.geometric,positioning}

\begin{document}
\begin{tikzpicture}[decision/.style={diamond, draw, text width=4.5em, text badly centered, node distance=3.5cm, inner sep=0pt},
                    block/.style   ={rectangle, draw, text width=6em, text centered, rounded corners, minimum height=4em, minimum height=2em},
                    cloud/.style   ={draw, ellipse, minimum height=2em},
                    line/.style    ={draw,-latex'},
                    node distance = 1cm, 
                    auto]
    \node [block] (1st) {1st};
    \node [block, right= of 1st]  (2nd1) {2nd1};
\begin{scope}[node distance=2mm and 10mm]%Here we change it for everything inside this scope
    \node [block, above= of 2nd1] (2nd2) {2nd2};
    \node [block, below= of 2nd1] (2nd3) {2nd3};
    \node [block, right= of 2nd1] (3rd1) {3rd1};
    \node [block, above= of 3rd1] (3rd2) {3rd2};
    \node [block, above= of 3rd2] (3rd3) {3rd3};
\end{scope}
    \node [block, below= of 3rd1] (3rd4) {3rd4};
    \node [block, below= of 3rd4] (3rd5) {3rd5};

    \path [line] (1st) -- (2nd1);
    \path [line] (2nd1) -- (2nd2);
    \path [line] (2nd1) -- (2nd3);
    \path [line] (2nd2) -- (3rd3);
    \path [line] (2nd1) -- (3rd1);
    \path [line] (1st) -- (2nd1);
\end{tikzpicture}
\end{document}

enter image description here

Best Answer

Related Solutions

[Tex/LaTex] Rotate a node but not its content: the case of the ellipse decoration

[Tex/LaTex] How to define the default vertical distance between nodes

Related Question