boxesframedmarginsspacing
I included a graphic the following way:
\includegraphics[width=1\textwidth]{questionnaire1.png}
Then I changed it so that a frame is drawn around the graphic:
\fbox{\includegraphics[width=1\textwidth]{questionnaire1.png}}
But now, the whole graphic with the border is move 1-2 cm to the right side of the page so that is not in line with the other content. How can I change this?
Use either the ifoddpage or the changepage package to check on which page the figure is. It needs two latex runs to determine the correct page number.
If the changepage package is used it should be loaded with the strict option, because otherwise the used page number might not be correct in all cases (when TeX reads more material to look for a page break etc.). Alternatively the macro \strictpagecheck can be placed before \checkoddpage.
The trick is to use \makebox[\textwidth] so that the box is officially only \textwidth long which also avoids "Overfull hbox" errors. Then the second optional argument of \makebox is used to align it either to the right or left:
\documentclass{scrbook}
\usepackage{graphicx}
\usepackage{ifoddpage}
%or: \usepackage[strict]{changepage}
\begin{document}
\begin{figure}[h]
%\setcapwidth{0.6\textwidth}
\checkoddpage
\edef\side{\ifoddpage l\else r\fi}%
\makebox[\textwidth][\side]{%
\begin{minipage}[t]{0.59\textwidth}
\centering
\includegraphics[width=\textwidth]{gfx-1}
\caption{Caption 1}
\end{minipage}%
\hfill
\begin{minipage}[t]{0.59\textwidth}
\centering
\includegraphics[width=\textwidth]{gfx-2}
\caption{Caption 2}
\label{fig:free-lunch}
\end{minipage}%
}%
\end{figure}
\end{document}
I have something like this as an example on my website. See also this TeX FAQ from where I got the idea.
The problem occurs because of the subtle length-management when using a minipage within a minipage. The outer minipage of width 0.48\linewidth sets the line width within that minipage to 0.48\linewidth. If the inner minipage is set to a width of 0.48\linewidth, it is actually 0.2304 of the original \linewidth, since the nested minipage compounds the lengths. You also need to remove the spurious space after \fbox{ by using %. Using this is better:
\documentclass{article}
\usepackage{caption,subcaption}%
\usepackage{calc}% http://ctan.org/pkg/calc
\usepackage[showframe]{geometry}% http://ctan.org/pkg/geometry
\begin{document}
\noindent\begin{minipage}[t]{0.48\linewidth}%
\centering
\fbox{%
\begin{minipage}[t]{\linewidth-2\fboxsep-2\fboxrule}% Remove fbox rule/sep width
picture1
\end{minipage}}
\captionof{figure}{picture1}\label{fig:picture1}
\end{minipage}\hfill
\begin{minipage}[t]{0.48\linewidth}%
\centering
\fbox{%
\begin{minipage}[t]{\linewidth-2\fboxsep-2\fboxrule}% Remove fbox rule/sep width
picture2
\end{minipage}}
\captionof{figure}{picture2}\label{fig:picture2}
\end{minipage}
\end{document}
If you're interested in a vertical divider between the two images to visually separate them from one another, one could typeset the entire structure inside a multicols environment:
\documentclass{article}
\usepackage{caption,subcaption}%
\usepackage{calc}% http://ctan.org/pkg/calc
\usepackage{multicol}% http://ctan.org/pkg/multicol
\usepackage{lipsum}% http://ctan.org/pkg/lipsum
\begin{document}
\lipsum[1]
\renewcommand{\columnseprule}{0.4pt}% Columns are separated by rule of width 0.4pt
\begin{multicols}{2}% Two-column layout
\setlength{\parindent}{0pt}% No paragraph indent
\begin{minipage}[t]{\linewidth}%
\fbox{%
\begin{minipage}[t]{\linewidth-2\fboxsep-2\fboxrule}% Remove fbox rule/sep width
picture1
\end{minipage}}
\captionof{figure}{picture1}\label{fig:picture1}
\end{minipage}
\begin{minipage}[t]{\linewidth}%
\fbox{%
\begin{minipage}[t]{\linewidth-2\fboxsep-2\fboxrule}% Remove fbox rule/sep width
picture2
\end{minipage}}
\captionof{figure}{picture2}\label{fig:picture2}
\end{minipage}
\end{multicols}
\lipsum[2]
\end{document}
The use of the calc package is merely for calculation of lengths. And, the geometry package is used to highlight the page frame. Also, the lipsum package provides some dummy text.
Best Answer
I would add
\noindentto avoid paragraph indention, which might be the case here. Also the\fboxadds some space around its content, i.e.\fboxsepon each side. I would subtract this amount from the image width to have the image including the frame exactly\textwidthwide. You could also subtract the line width of the frame as well.