I shall prefix this with my standard "rubber stamps":
- This is not really an answer, but is a bit longer than a comment allows.
- You should read "A Convenient Setting of Global Analysis" by Kriegl and Michor. In particular, section 45 (Manifolds of Riemannian Metrics) and section 27.11ff (Submanifolds, in particular there's a good discussion of the necessity of the splitting condition).
I should also say that, as I mentioned in the comments above, I don't have access to the two articles cited so I can only speculate on what they are trying to achieve.
Firstly, many times in infinite dimensional analysis one wants to work with a space $X$ but it's tricky, so we work instead with a space $Y$. Only there's not one particular choice for $Y$, there's lots. And sometimes if we can say something for every such $Y$ in a compatible way then we can deduce that it also holds for our original $X$. The key here is the "in a compatible way". A common example is studying some infinite dimensional Frechet manifold (such as here) by expressing it as an inverse limit of Hilbert manifolds. Now each of those Hilbert manifolds has its own Hilbertian structure, and so (for example) is diffeomorphic to an open subset of some Hilbert space. But just because these exist, doesn't mean that they exist nicely with respect to each other. So to make some general statement about all of them, sometimes you have to sacrifice the really strong structure you have and work with something in the middle.
In the case of loop spaces, to take an example I do know something a little about, then one can always consider the various Sobolev spaces of loops, say $L^s M$. Each of those is a Hilbert manifold and its tangent bundle is thus a Hilbert bundle and can be given a strong metric. However, the "natural" structure group of $T L^s M$ is $LO_n$, loops on the orthogonal group. This only acts orthogonally on the "usual" Hilbert completion of $L\mathbb{R}^n$. So any other orthogonal structure requires changing the structure group. Admittedly, the space of all the choices is contractible, but that's homotopy theory and by passing to Hilbertian manifolds one is essentially declaring that one wants to do analysis so one would have to keep track of all the homotopies involved and keep taking them into account. (To make the point a little clearer, it's the difference between knowing that a solution exists and actually going out and finding it. If you really need to know the solution, knowing that it exists gives you a little hope but doesn't really help you actually write it down.)
I would also like to say that the usual classification of orthogonal structures into just "weak" and "strong" is a little simplistic. There is almost always some addition structure in the background (usually related to the structure group) and taking it into account can give a much finer picture. I have such a finer classification in my paper How to Construct a Dirac Operator in Infinite Dimensions together with examples of the different types.
So to return to the actual question. Let me see if I can simplify it a little. We can work locally, and in the actual question you are only concerned with what happens over the submanifold. So we have some open subset of a model space, $U$, and a Hilbert space, $H$, two trivial bundles over $U$ modelled on $H$, say $E_1$ and $E_2$, and an inclusion of bundles $E_1 \to E_2$ such that the image of each fibre is closed. Then we want to know if $E_2^\top$ is locally trivial. We can, if we choose, impose some codimensionality conditions on the inclusions.
Adjointing, we have a smooth map $\theta : U \to \operatorname{Incl}(H,H)$ where $\operatorname{Incl}(H,H)$ is the space of closed linear embeddings of $H$ in itself.
Now we see where the crux of the matter lies. What topology do we have on $\operatorname{Incl}(H,H)$? We have lots of choices. The two most popular are the strong and weak topologies. Without making further assumptions, we can only assume that we have the weak topology! Where this distinction comes into play is that the weak topology is very badly behaved. With the weak topology, $\operatorname{Incl}(H,H)$ is not an ANR so there's no nice extension results. With the strong topology, it's a CW-complex and so lots of nice things follow - in particular, orthogonal complementation will be continuous and the complement will be a locally trivial bundle.
Imposing finite codimensionality doesn't help either. That's a bit like saying that you know that you end up in Fredholm operators. Again, in the strong case then that's okay since the index is well-defined and so the complement will have constant dimension and be locally trivial. With the weak topology, the index is not continuous as, with the weak topology, the space of Fredholm operators is contractible.
So there's where to find your counterexample: find such an inclusion $E_1 \to E_2$ such that the adjoint map is only continuous into the weak topology, not the strong one. A good source of such examples is with the obvious representation of a Lie group $G$ on $L^2(G)$. I expect that with a bit of bundle-crunching, this could be turned into an example.
It is just possible that the bits of your question that I threw out would save you (namely that the bundles were tangent bundles) but I doubt it since I expect that you could take an example as I outlined above and consider that as the inclusion of manifolds, then the tangent bundles of that inclusion would have the same properties of the inclusion itself. That is, if you can find a counterexample, $E_1 \to E_2$, to my version of your question then viewing $Y = E_1$ and $X = E_2$ then I think you get a counterexample to your original setting.
Best Answer
Maybe this is not what you are after, but at least for line bundles, there is a classification of line bundles with connection up to isomorphism in terms of smooth Deligne cohomology. This is explained in Brylinski's Loop spaces, characteristic classes and geometric quantization -- particularly Theorem 2.2.12.