According to the textbook, and Wolfram Alpha the above is correct.
Here is the step by step procedure from Wolfram Alpha for evaluating the indefinite integral:
Take the integral: $$\int\sqrt{1-\cos(x)}\,dx$$ For the integrand $\sqrt{1-\cos(x)}$, substitute $u=1-\cos(x)$ and $du=\sin(x)\,dx$: $$=\int-\frac{1}{\sqrt{2-u}}\,du$$ Factor out constants: $$=-\int\frac{1}{\sqrt{2-u}}\,du$$ For the integrand $1/\sqrt{2-u}$, substitute $s=2-u$ and $ds=-du$: $$=\int\frac{1}{\sqrt{s}}\,ds$$ The integral of $1/\sqrt{s}$ is $2\sqrt{s}$: $$=2\sqrt{s}+\text{constant}$$ Substitute back for $s=2-u$: $$=2\sqrt{2-u}+\text{constant}$$ Substitute back for $u=1-\cos(x)$: $$=2\sqrt{\cos(x)+1}+\text{constant}$$ Which is equivalent for restricted $x$ values to: $$\boxed{=-2\sqrt{1-\cos(x)}\cot\big(\frac{x}{2}\big)+\text{constant}}$$
I understand up to the below (which is a valid solution to the integral): $$2\sqrt{\cos(x)+1}+\text{constant}$$
However, if you evaluate this at $2\pi$ and $0$, you get the same thing, so the definite integral evaluates to zero.
After, you transform the above to: $$-2\sqrt{1-\cos(x)}\cot\big(\frac{x}{2}\big)+\text{constant}$$
The expression is indeterminate at $2\pi$ and $0$ of the form $0 \times \infty$. So I guess you would set up a limit and then use L'Hospital's rule to evaluate the expression at $2\pi$ and $0$ and get the answer to the definite integral?
In any case, all this seems strange. Why should the definite integral evaluated one way give $0$, and in another way give something else?
Now noting that
Best Answer
$$ \int_0^{2\pi}\sqrt{1-\cos x}\,dx=\int_0^{2\pi}\sqrt{2\sin^2\frac{x}{2}}\,dx =\sqrt{2}\int_0^{2\pi}\sin\frac{x}{2}\,dx=-2\sqrt{2}\cos\frac{x}{2}\Big|_0^{2\pi}=4\sqrt{2}. $$