Yes, you are correct on the first question.
For the second, there are four positions, the first of which has $9$ possible values, (can't be zero), then the second position has 9 possible values it can take on (subtracting 1 from 10 possible values since it can't be the same number as the first position. Etc...
$$9 \cdot 9\cdot 8 \cdot 7 = 4536$$
Hint: There are two types of $4$ digit odd integers with all digits different: (i) First digit is even ($2,4,6,8$) or (ii) first digit is odd. Count the Type (i) numbers, the Type (ii) numbers, and add.
Type (i): There are $4$ choices for the first digit. For each of these choices there are $5$ choices for the last digit. For each of the choices we have made so far, there are $8$ choices for the second digit, and for each such choice $7$ choices for the third, a total of $(4)(5)(8)(7)$.
Now it's your turn: make a similar calculation for Type (ii).
The analysis for the even numbers will be roughly similar. The two cases are (i) last digit is $0$ and (ii) last digit is not $0$.
Remark: The tricky thing is that the first digit cannot be $0$. A slightly nicer approach, I think, is to first allow $0$ as a first digit, and then take away the "numbers" with first digit $0$, which we should not have counted.
So for odd numbers, if we allow $0$ as a first digit, we can choose the last digit in $5$ ways, and then for the rest we have $(9)(8)(7)$ choices, for a total of $(5)(9)(8)(7)$.
Now if we have $0$ as the first digit, the rest can be filled in $(5)(8)(7)$ ways.
So our answer is $(5)(9)(8)(7)-(5)(8)(7)=2240$.
For the evens, the same analysis gives $(5)(9)(8)(7)-(4)(8)(7)$.
Best Answer
For every collection of $4$ distinct digits, there is a unique way to arrange the digits so that they are decreasing, and a unique way to arrange them so that they are increasing. This gives $2 \binom{10}{4}$ different sequences that are increasing or decreasing, but not all correspond to a four-digit number. For increasing sequences, you cannot have $0$ as a first digit. This rules out $\binom{9}{3} = 84$ possibilities. So the total is $2(210) - 84=336 \neq 343$...?